Categorize remaining regex-related libcxx test failures#5587
Merged
StephanTLavavej merged 1 commit intomicrosoft:mainfrom Jul 15, 2025
Merged
Conversation
StephanTLavavej
approved these changes
Jun 14, 2025
Member
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
Member
|
Thanks for investigating what remaining work is needed! 🕵️ 🧑🔬 💡 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are two remaining reasons for failing libcxx tests related to
regex:match_prev_availis broken, see [libc++]std::regexmatch_prev_availimplementation is regressed llvm/llvm-project#74838.<regex>: What names can and shouldregex_traits::lookup_collatename()recognize? #5393. (If preferred, we could make an additional distinction: the "locale" test failures are about the "can" in the issue question, the failures of the other grammar-specific tests are about the "should", and the failure of thelookup_collatename()test is about both.)