<regex>: Restrict control letters in escapes to alphabetic ASCII characters#5524
Merged
StephanTLavavej merged 4 commits intomicrosoft:mainfrom May 22, 2025
Merged
Conversation
muellerj2
commented
May 18, 2025
StephanTLavavej
approved these changes
May 20, 2025
Member
|
Thanks! 😻 I pushed minor changes, please meow if I was confused. |
Member
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
Member
|
There is no escape for regex bugs! 😹 🤪 🤣 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Towards #995. ECMAScript 15.10.1 defines the production
ControlLettersuch that only ASCII alphabetic characters are allowed. Such restricted character sets are often extended to corresponding POSIX character classes (to include Unicode characters) by Boost.Regex or<regex>implementations. But such an extension doesn't make much sense in this specific case, because these\c+ letter escapes are supposed to emulate what pressing Ctrl + ASCII character does in the terminal. (It would actually make more sense to support "\c[" and similar, but the ECMAScript standard doesn't say so.)Alternative: If non-ASCII characters should remain supported, we could query the bitmask of the character class "alpha" from the traits class.