<flat_map>: drop bogus exception specifications#5460
Merged
StephanTLavavej merged 1 commit intomicrosoft:feature/flat_mapfrom May 2, 2025
Merged
<flat_map>: drop bogus exception specifications#5460StephanTLavavej merged 1 commit intomicrosoft:feature/flat_mapfrom
<flat_map>: drop bogus exception specifications#5460StephanTLavavej merged 1 commit intomicrosoft:feature/flat_mapfrom
Conversation
Remove these exception specifications: * move-with-allocator constructor throws because allocator throws * ditto the extracted machinery _Extract_using_allocator * ditto copy assignment Bugs introduced in microsoft#5454, before that there was only one of them, and it was in a constructor that was never called.
StephanTLavavej
approved these changes
May 2, 2025
Member
|
Thanks for noticing and fixing this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove these exception specifications:
_Extract_using_allocatorBugs introduced in #5454, before that there was only one of them, and it was in a constructor that was never called.
I'm not sure if move constructor and move assignment exception specifications are right. That's vector-like thing we have in
flat_map, not necessarilyvector, what if it might not havenoexceptmoves.