vector_algorithms.cpp: cleanup#5429
Merged
StephanTLavavej merged 7 commits intomicrosoft:mainfrom Apr 29, 2025
Merged
Conversation
Contributor
Author
|
Added another commit with |
StephanTLavavej
approved these changes
Apr 24, 2025
Member
|
Thanks, these changes are great - especially the count-in-bytes and unsigned long mask changes! 😻 I pushed a syntax nitpick and a comment fix. STL SEES ALL. |
Member
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
Member
🧹 🚀 😸 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix accumulated inconsistencies in
vector_algorithms.cpp, separate commit each:const, lately I've been trying to addconsteverywhere, but there is missing one in older code_CSTD, the C run time things used unqualified in this file in some other places_Avx2_tail_mask_32now takes bytes count. It is odd from the perspective of the function itself, but almost every call site has bytes, and even for the ones that don't, the lack of multiplication by 4 and multiplication by 2 instead of by 8 look odd.Deliberately skipped namespace as per #5418 for now. These look more controversial, so I'd do just clean stuff first.