Closed
Conversation
Contributor
Author
|
Actually I was wrong, |
Contributor
|
FYI #3965 fixed some bugs around self assignment. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Towards #1485.
On self-assignment, including self-move-assignment,
anyresets to empty, then calls_Move_fromon itself, which treats emptyanyas_Any_representation::_Trivialand does self-memcpy.Self-
memcpydoes seem unacceptably squirrely.There are number of ways to fix this issue. We can do
thischeck directly inoperator=s, to avoid any other potential impact. Or we can do the check for emptyanydirectly in_Move_from, to optimize other emptyanyassignment in addition.I've arbitrarily chosen to do this in
_Assign, to keep ruining theanythat is being self-assigned, do it in just one place, and not do any changes beyond the needed.