<random>: Fast discard() for minstd_rand and minstd_rand0 via fast exponentiation#5412
Merged
StephanTLavavej merged 5 commits intomicrosoft:mainfrom Apr 22, 2025
Merged
Conversation
<random>: Fast discard() for minstd_rand and minstd_rand0 via fast exponentiation
StephanTLavavej
approved these changes
Apr 17, 2025
Member
|
Thanks! 😻 I cleaned up a mistakenly added file, added a benchmark, and got the following hilarious results on my 5950X:
Skipping an exponential amount of work is pretty awesome. |
Member
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
Member
|
Thanks for perhaps the biggest speedup in the STL ever! ⏱️ 😻 🐱 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
discard() minstd_rand and minstd_rand0 now takes logarithmic time
due to fast exponentiation and avoiding constant divisions.