<regex>: Permit escaping of closing brackets in POSIX regexes#5399
Merged
StephanTLavavej merged 1 commit intomicrosoft:mainfrom Apr 22, 2025
Conversation
StephanTLavavej
approved these changes
Apr 11, 2025
Member
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
Member
|
Thanks for bringing us into the future of POSIX! 🛸 🚀 🪐 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short follow-up to #5380 to support escapes for closing brackets in POSIX regexes in accordance with the most recent POSIX standard version: https://pubs.opengroup.org/onlinepubs/9799919799/basedefs/V1_chap09.html#tag_09_03_02 for basic and https://pubs.opengroup.org/onlinepubs/9799919799/basedefs/V1_chap09.html#tag_09_04_02 for extended regexes.
Because of the (expected) test failures caused by this change, I noticed that the tests in
gh_5244_atomescape_posix_commonare called twice forextendedandegrepfromtest_gh_5244_atomescape_extended_or_egrep: Once viagh_5244_atomescape_posix_not_awkand once viagh_5244_atomescape_extended_egrep_awk. That's once more than necessary, so let's get rid of this double-testing. I opted to remove the call ofgh_5244_atomescape_posix_commoningh_5244_atomescape_extended_egrep_awk, but this means a call has to be added togh_5244_atomescape_awkso that these common POSIX tests are still exercised in awk mode.