Make unique_lock and shared_lock use self-swap implementation of move assignment#5337
Merged
StephanTLavavej merged 5 commits intomicrosoft:mainfrom Mar 13, 2025
Merged
Conversation
StephanTLavavej
requested changes
Mar 12, 2025
AlexGuteniev
commented
Mar 12, 2025
StephanTLavavej
approved these changes
Mar 12, 2025
Member
|
Thanks! 😸 Pushed a couple of trivial nitpicks. I observe that |
Member
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
StephanTLavavej
approved these changes
Mar 12, 2025
Member
|
I had to push an additional commit for my eternal nemesis, |
Member
|
Thanks for updating our implementation to Do What The Standard Says and adding test coverage! ✅ 😻 ☑️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #5290
Due to pre-existing self-assignment check, the implementation before the change passes the test.
Still I think it worth making closer to the WP.