Skip to content

<spanstream>: Fix ambiguity among constructors of basic_ispanstream#5309

Merged
StephanTLavavej merged 1 commit intomicrosoft:mainfrom
frederick-vs-ja:ispanstream-ctors
Feb 25, 2025
Merged

<spanstream>: Fix ambiguity among constructors of basic_ispanstream#5309
StephanTLavavej merged 1 commit intomicrosoft:mainfrom
frederick-vs-ja:ispanstream-ctors

Conversation

@frederick-vs-ja
Copy link
Contributor

By removing the non-standard constructor overload from span<const _Elem>.

Fixes #5308.

@frederick-vs-ja frederick-vs-ja requested a review from a team as a code owner February 24, 2025 01:52
@StephanTLavavej StephanTLavavej added the bug Something isn't working label Feb 24, 2025
@StephanTLavavej StephanTLavavej self-assigned this Feb 24, 2025
@StephanTLavavej StephanTLavavej removed their assignment Feb 24, 2025
@StephanTLavavej StephanTLavavej self-assigned this Feb 24, 2025
@StephanTLavavej
Copy link
Member

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit 25cfafb into microsoft:main Feb 25, 2025
39 checks passed
@StephanTLavavej
Copy link
Member

Thanks for fixing this compile-time regression affecting a basic scenario! 😻 🛠️ 🪄

@frederick-vs-ja frederick-vs-ja deleted the ispanstream-ctors branch February 25, 2025 01:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

<spanstream>: Constructing ispanstream from string no longer compiles since VS 17.13

2 participants