Expand workaround for EDG bug in P0323R12_expected#5249
Merged
StephanTLavavej merged 2 commits intomicrosoft:mainfrom Jan 24, 2025
Merged
Expand workaround for EDG bug in P0323R12_expected#5249StephanTLavavej merged 2 commits intomicrosoft:mainfrom
P0323R12_expected#5249StephanTLavavej merged 2 commits intomicrosoft:mainfrom
Conversation
… ODR-used. Co-authored-by: Casey Carter <Casey@Carter.net>
The IntelliSense compiler just disabled compatibility with an outdated MSVC overload resolution bug, causing an apparent regression in `P0323R12_expected`. These `static_assert`s that were previously passing - but for the wrong reason - now fail with VS trunk. It looks a lot like VSO-1601179, so let's just expand the existing conditional to cover the new failures. Co-authored-by: Casey Carter <Casey@Carter.net>
zacklj89
approved these changes
Jan 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Copy of #5246, but restructured into two commits.
@CaseyCarter left Microsoft, so the CLA bot is blocking his original PR. The changes were written before he left, so Microsoft owns them, and I can copy them here.