Skip to content

<xmemory>: Tolerate bogus const-overloading in iterators passed to uninitialized_meow()#5170

Merged
StephanTLavavej merged 2 commits intomicrosoft:mainfrom
StephanTLavavej:bill-and-teds-bogus-iterators
Dec 13, 2024
Merged

<xmemory>: Tolerate bogus const-overloading in iterators passed to uninitialized_meow()#5170
StephanTLavavej merged 2 commits intomicrosoft:mainfrom
StephanTLavavej:bill-and-teds-bogus-iterators

Conversation

@StephanTLavavej
Copy link
Member

In an ideal world with infinite capacity, we would push through RWC fixes as we did with #5105. However:

  • 🎅
  • These fixes will be more intrusive than adding #include <chrono>.
  • I suspect that a fair amount of code will be affected and LLVM is just the first canary, even though uninitialized_meow() is relatively obscure.

@StephanTLavavej StephanTLavavej added the enhancement Something can be improved label Dec 7, 2024
@StephanTLavavej StephanTLavavej requested a review from a team as a code owner December 7, 2024 19:22
@CaseyCarter CaseyCarter removed their assignment Dec 7, 2024
@StephanTLavavej StephanTLavavej self-assigned this Dec 12, 2024
@StephanTLavavej
Copy link
Member Author

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit 0372e78 into microsoft:main Dec 13, 2024
@StephanTLavavej StephanTLavavej deleted the bill-and-teds-bogus-iterators branch December 13, 2024 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Something can be improved

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants