Skip to content

Globally suppress C5278#5163

Merged
CaseyCarter merged 1 commit intomicrosoft:mainfrom
CaseyCarter:type-trait-warning
Dec 5, 2024
Merged

Globally suppress C5278#5163
CaseyCarter merged 1 commit intomicrosoft:mainfrom
CaseyCarter:type-trait-warning

Conversation

@CaseyCarter
Copy link
Contributor

This is a new warning MSVC is adding to steer users away from attempting to specialize the type traits as forbidden by N4993 [meta.rqmts]/4. Since MSVC implements many of the type traits in the compiler, such specializations are generally ignored to the confusion of users who trigger the UB.

This is a mirror of the STL portion of MSVC-PR-596210.

This is a new warning MSVC is adding to steer users away from attempting to specialize the type traits as forbidden by N4993 [meta.rqmts]/4. Since MSVC implements many of the type traits in the compiler, such specializations are generally ignored to the confusion of users who trigger the UB.

This is a mirror of the STL portion of MSVC-PR-596210.
@CaseyCarter CaseyCarter added the enhancement Something can be improved label Dec 5, 2024
@CaseyCarter CaseyCarter requested a review from a team as a code owner December 5, 2024 01:45
@StephanTLavavej
Copy link
Member

Verified that this works with the older Preview compiler as we've already silenced mortals "warning C4619: #pragma warning: there is no warning number 'number' (/Wall)"

@StephanTLavavej StephanTLavavej removed their assignment Dec 5, 2024
@CaseyCarter CaseyCarter merged commit 89ca073 into microsoft:main Dec 5, 2024
@CaseyCarter CaseyCarter deleted the type-trait-warning branch December 5, 2024 18:49
@CaseyCarter
Copy link
Contributor Author

Merged without Changelogging - I doubt this change is interesting to anyone not an STL dev.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Something can be improved

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants