Implement LWG-4112 has-arrow should require operator->() to be const-qualified#5152
Merged
StephanTLavavej merged 4 commits intomicrosoft:mainfrom Dec 5, 2024
Merged
Conversation
cpplearner
reviewed
Nov 27, 2024
cpplearner
reviewed
Nov 27, 2024
CaseyCarter
approved these changes
Nov 27, 2024
Contributor
|
I pushed a commit to remove the unused function bodies and data members from the two implementations of |
StephanTLavavej
approved these changes
Nov 27, 2024
Member
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
Member
|
I can haz arrow? 🐈 🍔 😋 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5116. This affects
filter_view&join_view's iterators.Skipped libcxx test:
std/ranges/range.adaptors/range.join/range.join.iterator/arrow.pass.cpp