<regex>: Small cleanups#5058
Merged
StephanTLavavej merged 9 commits intomicrosoft:mainfrom Nov 8, 2024
Merged
Conversation
CaseyCarter
approved these changes
Oct 31, 2024
StephanTLavavej
approved these changes
Oct 31, 2024
Member
|
Thanks! 😸 FYI @CaseyCarter I pushed minor changes after you approved. Also, in case it wasn't just a typo - note that "simply" is an adverb, while "simplify" is a verb. |
CaseyCarter
approved these changes
Nov 3, 2024
Member
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
Member
|
I had to push an additional commit to fix regressions found by our Perennial test suite. See the cited Standardese for const-default-constructible and https://godbolt.org/z/GeWYxf37f . |
StephanTLavavej
approved these changes
Nov 8, 2024
CaseyCarter
approved these changes
Nov 8, 2024
Member
|
Thanks for cleaning up one of our dustiest headers! 🌬️ 🧹 🪄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
std::char_traitsandsub_match.constto someoperator(). A (non-static, non-explicit-parameter)operator()withoutconstusually implies the status of the function can be modified, which is not the case for the touched functors.= default;and default member initializers for some classes.Maybe in a future PR: Moving some function bodies into class bodies. Separation doesn't seem necessary to me, but the change is a bit large.