Skip to content

<regex>: Fix goofy message for error_badbrace#5025

Merged
StephanTLavavej merged 1 commit intomicrosoft:mainfrom
5AIPAVAN:branch-3
Oct 21, 2024
Merged

<regex>: Fix goofy message for error_badbrace#5025
StephanTLavavej merged 1 commit intomicrosoft:mainfrom
5AIPAVAN:branch-3

Conversation

@5AIPAVAN
Copy link
Contributor

@5AIPAVAN 5AIPAVAN commented Oct 17, 2024

Fixes #4993
updated line 502 in regex.cpp
from : "contained an invalid range in a { expression }."
to : "contained an invalid range in a {} expression."

@5AIPAVAN 5AIPAVAN requested a review from a team as a code owner October 17, 2024 16:12
@StephanTLavavej StephanTLavavej added the enhancement Something can be improved label Oct 17, 2024
@StephanTLavavej StephanTLavavej changed the title updated line 502 in regex.cpp to solve issue <regex>: Goofy message for error_badbrace #4993 <regex>: Fix goofy message for error_badbrace Oct 17, 2024
@StephanTLavavej
Copy link
Member

StephanTLavavej commented Oct 17, 2024

I've updated the PR title to fix several issues:

  • The <regex> header is being edited here, not a file named regex.cpp
  • PR titles shouldn't mention hyper-details like line numbers
  • PR titles don't need to mention issue numbers; these are meaningless when viewing commit history

@StephanTLavavej StephanTLavavej self-assigned this Oct 21, 2024
@StephanTLavavej
Copy link
Member

StephanTLavavej commented Oct 21, 2024

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit 27b1f88 into microsoft:main Oct 21, 2024
@StephanTLavavej
Copy link
Member

StephanTLavavej commented Oct 21, 2024

Thanks for this diagnostic improvement and congrats on your second microsoft/STL commit! 🎉 🎉 😺

@StephanTLavavej StephanTLavavej added the regex meow is a substring of homeowner label Jun 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@StephanTLavavej StephanTLavavej StephanTLavavej approved these changes

Assignees

@StephanTLavavej StephanTLavavej

Labels

enhancement Something can be improved regex meow is a substring of homeowner

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

<regex>: Goofy message for error_badbrace

2 participants

@5AIPAVAN @StephanTLavavej