Skip to content

Use if constexpr in locale facets#5001

Merged
StephanTLavavej merged 4 commits intomicrosoft:mainfrom
cpplearner:if-constexpr-facet
Oct 12, 2024
Merged

Use if constexpr in locale facets#5001
StephanTLavavej merged 4 commits intomicrosoft:mainfrom
cpplearner:if-constexpr-facet

Conversation

@cpplearner
Copy link
Contributor

Towards #189

@cpplearner cpplearner requested a review from a team as a code owner October 3, 2024 08:05
@StephanTLavavej StephanTLavavej added the throughput Must compile faster label Oct 3, 2024
@StephanTLavavej StephanTLavavej self-assigned this Oct 3, 2024
@StephanTLavavej
Copy link
Member

Thanks, this is awesome! 😻 I pushed a small change to further simplify things, consistent with your other changes.

@StephanTLavavej StephanTLavavej removed their assignment Oct 3, 2024
@StephanTLavavej StephanTLavavej self-assigned this Oct 11, 2024
@StephanTLavavej
Copy link
Member

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit 5bb81f6 into microsoft:main Oct 12, 2024
@StephanTLavavej
Copy link
Member

Thanks for if constexprizing the world! 🌎 🎉 💯

@cpplearner cpplearner deleted the if-constexpr-facet branch October 13, 2024 03:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

throughput Must compile faster

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants