<cmath>, <limits>: Locally disable -Wnan-infinity-disabled for Clang#4990
Merged
StephanTLavavej merged 3 commits intomicrosoft:mainfrom Oct 12, 2024
Merged
Conversation
<limits>: Locally disable -Wnan-infinity-disabled for Clang<cmath>, <limits>: Locally disable -Wnan-infinity-disabled for Clang
fda6ed1 to
fe88346
Compare
CaseyCarter
approved these changes
Sep 29, 2024
Contributor
CaseyCarter
left a comment
There was a problem hiding this comment.
Suppressing these warnings at template parse time while allowing them at instantiation is an excellent solution. I didn't know this was possible before.
StephanTLavavej
approved these changes
Sep 30, 2024
Member
|
Thanks! 😸 ♾️ @CaseyCarter I pushed a macro refactoring after you approved, moving them to |
CaseyCarter
approved these changes
Sep 30, 2024
Member
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
Member
♾️ 🚫 #️⃣ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4931.
Possibly because of that
numeric_limits<FP>are implemeted as full specializations, when one attempts usemin()orepsilon(), Clang emits warning for Nan and Inf related functions, even if these functions are not themselves called.This PR suppresses
-Wnan-infinity-disabledin<limits>and<cmath>locally to avoid such false positives. When a user explicitly callsinfinity(),quiet_NaN(), orsignaling_NaN(), the warning is still triggered (Godbolt link).