<utility>: Privatize pair's internal non-Standard constructor#4979
Merged
StephanTLavavej merged 2 commits intomicrosoft:mainfrom Sep 28, 2024
Merged
<utility>: Privatize pair's internal non-Standard constructor#4979StephanTLavavej merged 2 commits intomicrosoft:mainfrom
<utility>: Privatize pair's internal non-Standard constructor#4979StephanTLavavej merged 2 commits intomicrosoft:mainfrom
Conversation
It's arguably conforming to leave the internal constructor public, because it must be called with 4 arguments, and no Standard constructor would be selected in such a call. However, it's possibly better to prevent accident calls to implementation details. Also move the deleted `operator=` overload to the private section for consistency, which should affects nothing.
CaseyCarter
reviewed
Sep 24, 2024
CaseyCarter
approved these changes
Sep 24, 2024
StephanTLavavej
approved these changes
Sep 24, 2024
Member
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
Member
|
Is it secret? Is it safe? 🍐 💍 🧙♂️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #4961 we made an internal secret constructor private. It's arguably conforming to leave the internal constructor of
pairpublic, because it must be called with 4 arguments, and no Standard constructor would be selected in such a call. However, it's possibly better to prevent accident calls to implementation details.Also move the deletedEdit: reverted.operator=overload to the private section for consistency, which should affect nothing.