<string>: Fix handling for char_traits<unicorn>#4951
Merged
StephanTLavavej merged 7 commits intomicrosoft:mainfrom Sep 19, 2024
Merged
<string>: Fix handling for char_traits<unicorn>#4951StephanTLavavej merged 7 commits intomicrosoft:mainfrom
<string>: Fix handling for char_traits<unicorn>#4951StephanTLavavej merged 7 commits intomicrosoft:mainfrom
Conversation
AlexGuteniev
approved these changes
Sep 12, 2024
tests/std/tests/GH_004930_char_traits_user_specialization/test.cpp
Outdated
Show resolved
Hide resolved
tests/std/tests/GH_004930_char_traits_user_specialization/test.cpp
Outdated
Show resolved
Hide resolved
tests/std/tests/GH_004930_char_traits_user_specialization/test.cpp
Outdated
Show resolved
Hide resolved
StephanTLavavej
approved these changes
Sep 19, 2024
Member
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
Member
🧵 🦄 🛠️ |
| // signed char and other unsigned integral types are supported as an extension. | ||
| // Use of other arithmetic types and nullptr_t should be rejected. | ||
| template <class _Ty> | ||
| constexpr bool _Is_implementation_handled_char_like_type = is_arithmetic_v<_Ty> || is_null_pointer_v<_Ty>; |
Contributor
There was a problem hiding this comment.
I came from the future to ask: why exactly is_arithmetic_v<_Ty> || is_null_pointer_v<_Ty>? Can we limit to is_integral<_Ty> ?
Contributor
There was a problem hiding this comment.
Ah, got it, that are impossible to specialize
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4930. Ideally, when
Tis an implementation-controlled type, special handling should be enabled forchar_traits<T>to reject more unintended element types. But the complete work is impractical, so this PR restricts the handling to arithmetic types andnullptr_t.Drive-by changes:
static_assertmessage to mentionchar8_t.TRANSITIONcomments in<regex>, but test coverage is currently missing (which would be complicated and weird).