<ranges>: rename views::iota and views::repeat parameters#4908
<ranges>: rename views::iota and views::repeat parameters#4908StephanTLavavej merged 1 commit intomicrosoft:mainfrom
<ranges>: rename views::iota and views::repeat parameters#4908Conversation
|
Thanks! 😻 This is a strict improvement over the status quo's currently terrible names, so I'm happy here. I observe that this isn't perfectly consistent with either the underlying views' parameters, or the Standard-depicted parameters, but I don't care enough to nitpick it further. (The views are the preferred interface for users, and the names you've chosen are a bit more descriptive than "value, bound", which is enough rationale for me.) I'll defer to Casey if he has other thoughts. |
After I made the commit I realised the same thing... I then also came to pretty much the same conclusion so opted to just create the PR anyway 😁. |
Hey, at least we didn't name them |
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
|
|
The Visual Studio IDE has an "inline parameter hint" feature which will show the parameter names inline. The STL generally has nice descriptive names which can make this feature helpful.
When I went to use
views::iotaI forgot if the second arg is a count or not, I was hoping the parameter names would save me a trip to cppreference, but alas, I was greeted with useless names.views::repeathas the same issue (which is my fault; I just copied and pasted iota)I also have a feature request to de-uglify them (might make another to not show the type information for these views, or I guess more generally, long nested templated types)