Update _MSVC_STL_UPDATE value to February 2020#486
Merged
StephanTLavavej merged 3 commits intomicrosoft:masterfrom Feb 6, 2020
Merged
Update _MSVC_STL_UPDATE value to February 2020#486StephanTLavavej merged 3 commits intomicrosoft:masterfrom
StephanTLavavej merged 3 commits intomicrosoft:masterfrom
Conversation
CaseyCarter
approved these changes
Feb 6, 2020
Contributor
Author
|
Some issue with build pipeline for x64? |
CaseyCarter
reviewed
Feb 6, 2020
Contributor
There are a bunch of source code checks that run only in the x64 build; it would be redundant to run equivalent checks in all four builds, so we picked x64. If you peek at the details
in this case it's complaining that you didn't clang-format |
This reverts commit 7e5b7b3.
StephanTLavavej
approved these changes
Feb 6, 2020
Member
|
Thanks, and congratulations on your first commit! (I’ll merge this to our Microsoft-internal repo later today. Usually we wait for a test run there to complete, but we know that |
Contributor
Author
|
Thank you all :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Checklist
Be sure you've read README.md and understand the scope of this repo.
If you're unsure about a box, leave it unchecked. A maintainer will help you.
_Uglyas perhttps://eel.is/c++draft/lex.name#3.1 or there are no product code changes.
verified by an STL maintainer before automated testing is enabled on GitHub,
leave this unchecked for initial submission).
members, adding virtual functions, changing whether a type is an aggregate
or trivially copyable, etc.).
the C++ Working Draft (including any cited standards), other WG21 papers
(excluding reference implementations outside of proposed standard wording),
and LWG issues as reference material. If they were derived from a project
that's already listed in NOTICE.txt, that's fine, but please mention it.
If they were derived from any other project (including Boost and libc++,
which are not yet listed in NOTICE.txt), you must mention it here,
so we can determine whether the license is compatible and what else needs
to be done.