<ranges>: Remove redundant _HAS_CXX23 guards#4724
Merged
StephanTLavavej merged 2 commits intomicrosoft:mainfrom Jun 18, 2024
Merged
<ranges>: Remove redundant _HAS_CXX23 guards#4724StephanTLavavej merged 2 commits intomicrosoft:mainfrom
<ranges>: Remove redundant _HAS_CXX23 guards#4724StephanTLavavej merged 2 commits intomicrosoft:mainfrom
Conversation
…specializations. These views are already guarded for C++23. Note that the primary template for `_Compile_time_max_size` is guarded by `_HAS_CXX23`, so these changes aren't risky - if we attempted to define specializations in C++20 mode, we'd get instant errors.
Member
Author
|
I'm speculatively mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
barcharcraz
approved these changes
Jun 14, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes redundant
_HAS_CXX23guards around_Compile_time_max_sizespecializations, for views that are already guarded for C++23.Note that these changes are very low risk because the primary template for
_Compile_time_max_sizeis guarded for C++23. If we attempted to specialize it in C++20 mode, we'd get instant errors:STL/stl/inc/ranges
Lines 44 to 55 in e36ee6c
This also adds a couple of
#endifcomments; they aren't strictly necessary but they helped me ripgrep for the redundant guards.Noticed while reviewing #4707.