Block building STL in wrong command prompt#4709
Block building STL in wrong command prompt#4709StephanTLavavej merged 5 commits intomicrosoft:mainfrom
Conversation
|
Our test suite doesn't use CMake Presets. STL/azure-devops/cmake-configure-build.yml Lines 32 to 39 in e36ee6c |
|
Can you also test building with the Visual Studio IDE? |
|
It seems VS Studio also doesn't use CMake Presets directly. VS IDE might parse the CMake Presets but it runs cmake like this: |
|
After looking into this deeper I'm not sure if it is even the right direction. |
|
@AlexGuteniev
So I think my patch can help with these issues, partly. But we also can make a patch for stl-lit.py. |
|
Thanks, this is awesome!! 😻 I pushed a commit to simplify the logic with CMake's (They also support regex I re-verified enabled and disabled cases in the terminal, and that the VS IDE works (actually the first time I've built the STL in the IDE 😹). |
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
|
Thanks for this quality-of-life improvement for contributors! 🪄 📈 😻 |









Fixes #4639
I didn't test ARM command prompts.