Skip to content

Tests: un-skip a few libc++ tests that were believed to have timing assumptions#4698

Merged
StephanTLavavej merged 1 commit intomicrosoft:mainfrom
cpplearner:patch-1
May 30, 2024
Merged

Tests: un-skip a few libc++ tests that were believed to have timing assumptions#4698
StephanTLavavej merged 1 commit intomicrosoft:mainfrom
cpplearner:patch-1

Conversation

@cpplearner
Copy link
Contributor

@cpplearner cpplearner commented May 28, 2024

  • std/atomics/atomics.types.operations/atomics.types.operations.wait/atomic_notify_all.pass.cpp
  • std/thread/thread.mutex/thread.lock/thread.lock.guard/adopt_lock.pass.cpp
  • std/thread/thread.mutex/thread.lock/thread.lock.guard/mutex.pass.cpp
  • std/thread/thread.threads/thread.thread.class/thread.thread.destr/dtor.pass.cpp
    • It doesn't seem to have timing assumptions. (There's a sleep_for call, which seems redundant.)
  • std/thread/thread.threads/thread.thread.class/thread.thread.member/detach.pass.cpp
    • It doesn't seem to have timing assumptions.

Drive-by: move two XFAIL: msvc tests down to "XFAILs WHICH PASS" section.

@cpplearner cpplearner requested a review from a team as a code owner May 28, 2024 05:53
@StephanTLavavej StephanTLavavej added the test Related to test code label May 28, 2024
@StephanTLavavej StephanTLavavej self-assigned this May 28, 2024
@StephanTLavavej
Copy link
Member

I'm nervous about anything that says "detach", but if it flakes out we can re-skip it. Thanks!

@StephanTLavavej StephanTLavavej removed their assignment May 29, 2024
@StephanTLavavej StephanTLavavej self-assigned this May 29, 2024
@StephanTLavavej
Copy link
Member

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit 872f476 into microsoft:main May 30, 2024
@StephanTLavavej
Copy link
Member

Thanks for improving our libc++ test coverage! ✅ 🎉 😸

@cpplearner cpplearner deleted the patch-1 branch June 29, 2024 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

test Related to test code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants