Optimize println() overloads added in P3142R0#4672
Merged
StephanTLavavej merged 12 commits intomicrosoft:mainfrom Oct 24, 2024
Merged
Optimize println() overloads added in P3142R0#4672StephanTLavavej merged 12 commits intomicrosoft:mainfrom
println() overloads added in P3142R0#4672StephanTLavavej merged 12 commits intomicrosoft:mainfrom
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
StephanTLavavej
approved these changes
Oct 22, 2024
Member
|
Thanks! 😻 I pushed a conflict-free merge with |
CaseyCarter
approved these changes
Oct 22, 2024
Member
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
Member
|
Thanks for figuring out the surprisingly complicated logic needed to make these functions fast! 🚀 😻 💚 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4630.
__std_print_newline_only_to_unicode_consoleto the import library to avoid potential branches aroundWriteConsoleW.sputcfor non-Unicode new line printing forostreamto reduce potential branches.fputcfor non-Unicode new line printing forFILE*as the function seems to be the simplest for the purpose in UCRT.