<ranges>: Replace one improper use of _Iter_value_t with iter_value_t in _Stable_sort_fn#4628
Merged
StephanTLavavej merged 1 commit intomicrosoft:mainfrom Apr 27, 2024
Conversation
As the use of `_Iter_value_t` appeared within the implementation details of C++20 `ranges::stable_sort`, it should be replaced with `iter_value_t`.
StephanTLavavej
approved these changes
Apr 25, 2024
Member
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
Member
|
Thanks for noticing this tiny cleanup among megabytes of source code! 🎯 😸 🧹 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As the use of
_Iter_value_tappeared within the implementation details of C++20ranges::stable_sort, it should be replaced withiter_value_t.See also #4436 (comment) - this should be the only occurence of
_Iter_value_tthat "Should always be C++20iter_value_t".