Move _Floating_type_traits-related functions#4615
Merged
StephanTLavavej merged 3 commits intomicrosoft:mainfrom Apr 26, 2024
Merged
Move _Floating_type_traits-related functions#4615StephanTLavavej merged 3 commits intomicrosoft:mainfrom
_Floating_type_traits-related functions#4615StephanTLavavej merged 3 commits intomicrosoft:mainfrom
Conversation
- Move `_Float_abs_bits`, `_Float_abs`, `_Is_nan`, and `_Is_finite` to `<type_traits>` to avoid including `<xutility>` in `<cmath>`cmath - Move `_Is_signaling_nan` and `_Is_inf` to `<complex>` as they are not used elsewhere. - Remove `_Float_copysign` as it's unused. - Reimplement `_Floating_max` and `_Floating_min` in a simpler way.
StephanTLavavej
approved these changes
Apr 21, 2024
Member
|
Thanks! I pushed a further simplification to use hexfloats. Note that this makes |
Member
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
Member
|
Thanks again for noticing these possibilities for improvement! 🪄 🚀 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Towards #3599.
_Float_abs_bits,_Float_abs,_Is_nan, and_Is_finiteto<type_traits>to avoid including<xutility>in<cmath>.<cmath>is not included._Is_signaling_nanand_Is_infto<complex>as they are not used elsewhere._Float_copysignas it's unused._Floating_maxand_Floating_minin a consistent way.