vector_algorithms.cpp: Fix ARM64EC build break#4538
Merged
StephanTLavavej merged 1 commit intomicrosoft:mainfrom Mar 28, 2024
Merged
vector_algorithms.cpp: Fix ARM64EC build break#4538StephanTLavavej merged 1 commit intomicrosoft:mainfrom
vector_algorithms.cpp: Fix ARM64EC build break#4538StephanTLavavej merged 1 commit intomicrosoft:mainfrom
Conversation
It's still within an unnamed namespace.
zacklj89
reviewed
Mar 28, 2024
zacklj89
approved these changes
Mar 28, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Followup to #4495.
The usage of
_Avx2_tail_mask_32()is always guarded by#ifndef _M_ARM64EC, and we need to do the same for the definition. (It's still within an unnamed namespace.)I'm adding a newline to make the preprocessor structure of the file clearer.