Skip to content

Fix #224: static_assert is_sorted().#451

Merged
StephanTLavavej merged 1 commit intomicrosoft:masterfrom
StephanTLavavej:fix_gh_224_static_assert_is_sorted
Jan 24, 2020
Merged

Fix #224: static_assert is_sorted().#451
StephanTLavavej merged 1 commit intomicrosoft:masterfrom
StephanTLavavej:fix_gh_224_static_assert_is_sorted

Conversation

@StephanTLavavej
Copy link
Member

Description

Now that #6 has been implemented, we can fix #224 by static_asserting is_sorted() for lookup tables. This guarantees safety with zero runtime cost.

Checklist

Be sure you've read README.md and understand the scope of this repo.

If you're unsure about a box, leave it unchecked. A maintainer will help you.

  • Identifiers in product code changes are properly _Ugly as per
    https://eel.is/c++draft/lex.name#3.1 or there are no product code changes.
  • The STL builds successfully and all tests have passed (must be manually
    verified by an STL maintainer before automated testing is enabled on GitHub,
    leave this unchecked for initial submission).
  • These changes introduce no known ABI breaks (adding members, renaming
    members, adding virtual functions, changing whether a type is an aggregate
    or trivially copyable, etc.).
  • These changes were written from scratch using only this repository,
    the C++ Working Draft (including any cited standards), other WG21 papers
    (excluding reference implementations outside of proposed standard wording),
    and LWG issues as reference material. If they were derived from a project
    that's already listed in NOTICE.txt, that's fine, but please mention it.
    If they were derived from any other project (including Boost and libc++,
    which are not yet listed in NOTICE.txt), you must mention it here,
    so we can determine whether the license is compatible and what else needs
    to be done.

@StephanTLavavej StephanTLavavej requested a review from a team as a code owner January 24, 2020 08:00
@StephanTLavavej StephanTLavavej force-pushed the fix_gh_224_static_assert_is_sorted branch from f10fa76 to 384b394 Compare January 24, 2020 08:26
@StephanTLavavej
Copy link
Member Author

I filed #455 to track the fact that we can't change validate.cpp yet (the tools don't use the freshly-built STL, d'oh).

@StephanTLavavej StephanTLavavej self-assigned this Jan 24, 2020
@StephanTLavavej StephanTLavavej merged commit 616cbea into microsoft:master Jan 24, 2020
@StephanTLavavej StephanTLavavej deleted the fix_gh_224_static_assert_is_sorted branch January 24, 2020 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

winapinls.cpp: static_assert is_sorted() for the lookup tables

3 participants