ADL-proof implementation of function, move_only_function, packaged_task, promise, and optional#4430
Merged
StephanTLavavej merged 6 commits intomicrosoft:mainfrom Mar 8, 2024
Conversation
Affected components: - `function` - `move_only_function` - `optional` - `promise` - `packaged_task`
- `_Unfancy` in `<memory>` - `_Make_unique_alloc` - `_Deallocate`
Contributor
|
Is |
Contributor
Author
Yes. The |
StephanTLavavej
approved these changes
Mar 5, 2024
Member
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
Member
|
Thanks for fixing another libcxx failure and qualifying all the things! 🛠️ 📈 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Towards #140 and #3100.
Unblocks one libcxx test:
std/utilities/function.objects/func.wrap/func.wrap.func/robust_against_adl.pass.cppAlso contains some drive-by and previously missed changes.
_STD-qualification for oneshared_ptr-related_Unfancycall (which is not strictly necessary)._STD-qualification for_Deallocateand_Make_unique_alloccalls (which are not strictly necessary IIUC)._Global_newfrom<xmemory>to<functional>because it is only used forfunction.Remaining unqualified
_Construct_in_placeand_Destroy_in_placecalls after this PR are all in containers andvalarray.