<vector>: Cast to the correct base type in vector<bool, Alloc>::_Orphan_range_unlocked#4276
Merged
StephanTLavavej merged 1 commit intomicrosoft:mainfrom Jan 11, 2024
Conversation
806aaea to
67147a1
Compare
67147a1 to
5abfd25
Compare
CaseyCarter
approved these changes
Jan 10, 2024
StephanTLavavej
approved these changes
Jan 10, 2024
Member
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
Member
|
Thanks for confirming my initial investigation and figuring out how to fix this libcxx failure! 📉 😻 🛠️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've confirmed that @StephanTLavavej's analysis for the related test failure was correct.
This PR exposes
_Mybasefor the convenience of casting, and removes some unnecessary_Difference_typemember type alias as driven-by changes. (It seems better to me to usedifference_typewhenever it's available.)Unblocks one libcxx test:
std/containers/sequences/vector.bool/emplace_back.pass.cpp