Partially analyze some SKIPPED libcxx tests#4270
Merged
StephanTLavavej merged 1 commit intomicrosoft:mainfrom Jan 9, 2024
Merged
Partially analyze some SKIPPED libcxx tests#4270StephanTLavavej merged 1 commit intomicrosoft:mainfrom
SKIPPED libcxx tests#4270StephanTLavavej merged 1 commit intomicrosoft:mainfrom
Conversation
StephanTLavavej
approved these changes
Dec 16, 2023
|
|
||
| # Itanium ABI assumptions that current_exception and rethrow_exception don't copy the exception object | ||
| # Itanium ABI assumptions that current_exception and rethrow_exception don't copy the exception object. | ||
| # The SKIPPED tests contain `XFAIL: msvc`, which is not well understood by the test harness. |
Member
There was a problem hiding this comment.
No change requested: I would have said "the MSVC-internal test harness" here because the GitHub test harness does understand XFAIL: msvc, but it's not worth resetting testing, this comment is a strict improvement.
Contributor
Author
There was a problem hiding this comment.
These tests successfully compile but fail to run. So they are affected by the ARM and ARM64 issue that you explained in
STL/tests/libcxx/expected_results.txt
Lines 1346 to 1355 in a888880
Member
|
Thank you, this is awesome! 😻 |
Member
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
Member
|
Thanks again for investigating these failures! 😻 🕵️ 💡 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.