Skip a sporadically failing libcxx test#4267
Merged
StephanTLavavej merged 2 commits intomicrosoft:mainfrom Dec 16, 2023
Merged
Conversation
Co-authored-by: A. Jiang <de34@live.cn>
zacklj89
approved these changes
Dec 16, 2023
Contributor
|
Some further analyses: This is probably a bug of MSVC STL and I've opened #4268. Not sure whether we can fix it before vNext. STL/tests/libcxx/expected_results.txt Lines 1103 to 1107 in e077eb6 Notes to myself, no change requested: it seems that MSVC will be happy if STL/tests/libcxx/expected_results.txt Lines 826 to 828 in e077eb6 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Followup to #4263. In the zillions of times that I ran libcxx locally, and in GitHub PR checks, and for MSVC locally, and in MSVC-PR checks, everything was fine - then the very first post-merge GitHub CI encountered a sporadic failure in an inherently bogus detached-threads test. This needs to be SKIPPED because we don't know if it'll pass or fail.
Additionally, I'm recording llvm/llvm-project#75611 that @frederick-vs-ja reported, as mentioned in #4263 (comment).