Update P1208R6_source_location after MSVC-internal changes#4220
Merged
StephanTLavavej merged 1 commit intomicrosoft:mainfrom Nov 29, 2023
Merged
Update P1208R6_source_location after MSVC-internal changes#4220StephanTLavavej merged 1 commit intomicrosoft:mainfrom
P1208R6_source_location after MSVC-internal changes#4220StephanTLavavej merged 1 commit intomicrosoft:mainfrom
Conversation
Member
Author
|
I'm speculatively mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
CaseyCarter
approved these changes
Nov 29, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MSVC-internal MSVC-PR-512527 and MSVC-PR-512932 updated the
P1208R6_source_locationtest without being properly mirrored to GitHub.We'll need to add
_MSVC_INTERNAL_TESTINGlogic until the fixed compiler ships. I've verified that this passes in both repos.