Turn niebloids into function objects#4098
Merged
StephanTLavavej merged 1 commit intomicrosoft:mainfrom Oct 20, 2023
Merged
Conversation
The core language doesn't seem to be any closer to providing first-class overload sets, and we're starting to get "bug" reports (DevCom-10450794) since the other standard library implementations simply implement these as (semiregular?) function objects. I'm not motivated to carry the battle to EWG, so let's just give up the dream and make these function objects.
Contributor
|
Am I correct and this change also fixes #3995 ? |
Contributor
Author
StephanTLavavej
approved these changes
Oct 18, 2023
Member
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
strega-nil-ms
approved these changes
Oct 19, 2023
Contributor
strega-nil-ms
left a comment
There was a problem hiding this comment.
I'm very happy about this haha
Member
|
Thanks for increasing global implementation consistency! 🌍 🌎 🌏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The core language doesn't seem to be any closer to providing first-class overload sets, and we're starting to get "bug" reports (DevCom-10450794) since the other standard library implementations simply implement these as (semiregular?) function objects.
This change removes the type
std::_Not_quite_object, promoting its member_Construct_tagto namespace scope since it is also used in the implementation ofjoin_viewandjoin_with_view.Fixes #4097