P2675R1 `<format>` generator converted from C++ to Python by fsb4000 · Pull Request #3994 · microsoft/STL

fsb4000 · 2023-08-26T14:16:35Z

Fixes #3908

Co-authored-by: achabense <60953653+achabense@users.noreply.github.com>

tools/unicode_properties_parse/format_width_estimate_intervals.py

tools/unicode_properties_parse/format_width_estimate_intervals.cpp

tools/unicode_properties_parse/format_width_estimate_intervals.py

> add comment for `fill_range` > rename some variables > type: bool~>int > refine names for the two function; simplify comments > better message

pr3994 review suggestions

tools/unicode_properties_parse/format_width_estimate_intervals.py

for pr3994 2

…generators.

StephanTLavavej · 2023-09-24T21:18:30Z

I've pushed a merge with main followed by:

Print the filename, timestamp, and C++ array.
Don't bother carefully wrapping; we need to clang-format anyways.
Use join to avoid a trailing comma interfering with clang-format.
Use a template string to make the C++ output clearer, like the other generators.
Format with Prettier.
Regenerate, capturing the filename and timestamp.
Cite the Standardese.

Because this table is changing over time, it's important to capture the filename/timestamp (with version info) so we can easily see when the table was last regenerated. The other changes allow the output to be copy-pasted into C++ and then clang-formatted, which is how the other generators behave too.

tools/unicode_properties_parse/format_width_estimate_intervals.py

strega-nil-ms · 2023-10-05T19:06:32Z

@StephanTLavavej, I've pushed changes (to change a comment explanation) after you approved.

StephanTLavavej · 2023-10-06T00:32:09Z

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

StephanTLavavej · 2023-10-06T18:45:59Z

📖 ⚡ 🐍

P2675R1 <format> generator converted from C++ to Python

7d2a326

fsb4000 requested a review from a team as a code owner August 26, 2023 14:16

This comment was marked as resolved.

Sign in to view

fsb4000 and others added 3 commits August 26, 2023 22:16

change a comment

2ba4369

Co-authored-by: achabense <60953653+achabense@users.noreply.github.com>

add some spaces

aec3166

remove unneded if

0956d67

CaseyCarter added the enhancement Something can be improved label Aug 29, 2023

StephanTLavavej added the format C++20/23 format label Aug 29, 2023

StephanTLavavej changed the title ~~P2675R1 <format> generator converted from C++ to Python~~ P2675R1 <format> generator converted from C++ to Python Aug 29, 2023

StephanTLavavej assigned StephanTLavavej and barcharcraz Sep 2, 2023

barcharcraz reviewed Sep 13, 2023

View reviewed changes

fsb4000 added 2 commits September 17, 2023 20:55

use a slice instead of a custom class, also remove input

6daea61

use enumerate

83ef03a

fsb4000 requested a review from barcharcraz September 17, 2023 14:03

strega-nil-ms reviewed Sep 19, 2023

View reviewed changes

achabense reviewed Sep 19, 2023

View reviewed changes

tools/unicode_properties_parse/format_width_estimate_intervals.cpp Show resolved Hide resolved

StephanTLavavej unassigned barcharcraz and StephanTLavavej Sep 20, 2023

apply code review suggestions

207e428

fsb4000 requested a review from strega-nil-ms September 21, 2023 14:32

achabense reviewed Sep 21, 2023

View reviewed changes

tools/unicode_properties_parse/format_width_estimate_intervals.py Show resolved Hide resolved

fsb4000 and others added 3 commits September 21, 2023 21:47

rephrase some comments

7c75b61

change the comments a bit

c8b9454

> restore the location of LINE_REGEX

294f157

> add comment for `fill_range` > rename some variables > type: bool~>int > refine names for the two function; simplify comments > better message

This comment was marked as resolved.

Sign in to view

Merge pull request #1 from achabense/review3994

c1f1aa6

pr3994 review suggestions

achabense reviewed Sep 22, 2023

View reviewed changes

tools/unicode_properties_parse/format_width_estimate_intervals.py Outdated Show resolved Hide resolved

> simplify print_ranges_1_vs_2

6e2c760

This comment was marked as resolved.

Sign in to view

achabense and others added 11 commits September 24, 2023 21:10

> add documentation for print_width_estimate_intervals

77ce232

> update regex to support both 15.0.0 and 15.1.0

8e88bb8

Merge pull request #2 from achabense/pr_to_3994_2

59615a2

for pr3994 2

Merge branch 'main' into fix3908

6fab139

Print the filename, timestamp, and C++ array.

e4f8665

Don't bother carefully wrapping; we need to clang-format anyways.

15320fa

Use join to avoid a trailing comma interfering with clang-format.

9d7958c

Use a template string to make the C++ output clearer, like the other …

8ebce49

…generators.

Format with Prettier.

ab8a275

Regenerate, capturing the filename and timestamp.

398e37d

Cite the Standardese.

13e3197

StephanTLavavej approved these changes Sep 24, 2023

View reviewed changes

achabense reviewed Sep 25, 2023

View reviewed changes

tools/unicode_properties_parse/format_width_estimate_intervals.py Outdated Show resolved Hide resolved

StephanTLavavej assigned strega-nil-ms Sep 27, 2023

This comment was marked as resolved.

Sign in to view

strega-nil-ms reviewed Oct 4, 2023

View reviewed changes

tools/unicode_properties_parse/format_width_estimate_intervals.py Outdated Show resolved Hide resolved

Update tools/unicode_properties_parse/format_width_estimate_intervals.py

fa0b783

strega-nil-ms approved these changes Oct 5, 2023

View reviewed changes

strega-nil-ms removed their assignment Oct 5, 2023

StephanTLavavej approved these changes Oct 5, 2023

View reviewed changes

StephanTLavavej self-assigned this Oct 6, 2023

StephanTLavavej merged commit d61f7e0 into microsoft:main Oct 6, 2023

fsb4000 deleted the fix3908 branch October 7, 2023 02:28

Conversation

fsb4000 commented Aug 26, 2023

Uh oh!

This comment was marked as resolved.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

This comment was marked as resolved.

Uh oh!

This comment was marked as resolved.

StephanTLavavej commented Sep 24, 2023

Uh oh!

Uh oh!

This comment was marked as resolved.

This comment was marked as resolved.

Uh oh!

strega-nil-ms commented Oct 5, 2023

Uh oh!

StephanTLavavej commented Oct 6, 2023

Uh oh!

StephanTLavavej commented Oct 6, 2023

📖 ⚡ 🐍

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants