Partially remove workaround for DevCom-1559808#3975
Partially remove workaround for DevCom-1559808#3975CaseyCarter merged 3 commits intomicrosoft:mainfrom
Conversation
This comment was marked as off-topic.
This comment was marked as off-topic.
CaseyCarter
left a comment
There was a problem hiding this comment.
What's here is good, but it's incomplete. DevCom-1559808 is closed as "fixed", so we need to remove any and all transition comments citing that bug. If we don't, we have TRANSITION comments waiting to respond to an event that is never going to happen. In practice that means we need to rereduce the issue that the remaining workaround in <algorithm> avoids, file that repro as a new DevCom bug, and update the bug number in the TRANSITION comment.
|
Thanks! The "no workaround" / "workaround" system is so great for making these changes easy to review. |
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
|
Thanks for helping to keep the code clean of workarounds for fixed bugs. |
Unblocks one libcxx test for MSVC.
I found that DevCom-1559808 is fixed during working on
_STD-/_RANGES-qualifying _Ugly function names.(And I've realized that structured bindings for
pair/subrangeinvolve ADL, so I'm planning changing the return type of_Partition_by_median_guess_commonto something likemeow_result).Edit: I was wrong. DevCom-1559808 isn't totally fixed.
Edit: I've filed DevCom-10452846 "Customized structured binding of subrange that refers to dynamic buffer incorrectly causes constant evaluation failure" for the remain issue.