<mdspan>: Product code review#3971
Merged
StephanTLavavej merged 12 commits intomicrosoft:feature/mdspan2from Aug 15, 2023
Merged
<mdspan>: Product code review#3971StephanTLavavej merged 12 commits intomicrosoft:feature/mdspan2from
<mdspan>: Product code review#3971StephanTLavavej merged 12 commits intomicrosoft:feature/mdspan2from
Conversation
They return `mapping_type::is_always_MEOW()` which is required to be a constant expression of type `bool` (N4950 \[mdspan.mdspan.overview\]/3, \[mdspan.layout.policy.reqmts\]/1, \[mdspan.layout.reqmts\]/22,24,26). The Standard should simply be enhanced to say `noexcept` here. Also introduce `constexpr bool _Result` to make this extra clear and improve debug codegen.
…ype&` in this constraint.
…the order of N4950 \[mdspan.accessor.default.overview\].
…ted by N4950 \[mdspan.extents.overview\] and \[mdspan.extents.cons\]/12.
…l_index()` to match its function parameters; it's always called with template argument deduction.
…ot commented as strengthened because it's `_Ugly`. It's now identical to the real multidimensional subscript operator except for the name, the comment, and the intentional lack of constraints.
…es the `span` overload. This is what N4950 \[mdspan.mdspan.members\]/6 depicts. It was being implicitly skipped before (`const array&` has the same effect), but adding this will make the following unification clearer.
This unifies them by wrapping the `array` in a `span`.
…not commented, it's `_Ugly`), then strengthen `operator[]` for `span`/`array`. This brings the `span`/`array` subscript operators up to parity with the multidimensional subscript operator.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mdspan::is_always_MEOW().mapping_type::is_always_MEOW()which is required to be a constant expression of typebool(N4950 [mdspan.mdspan.overview]/3, [mdspan.layout.policy.reqmts]/1, [mdspan.layout.reqmts]/22,24,26). The Standard should simply be enhanced to saynoexcepthere.constexpr bool _Resultto make this extra clear and improve debug codegen._Access_impl()is_Ugly.const _OtherIndexType&in this constraint.default_accessor, defineaccess()beforeoffset()to follow the order of N4950 [mdspan.accessor.default.overview].layout_stride::template mappingis unnecessary;layout_strideis not a template.explicitto the deduction guideextents(_Integrals...), depicted by N4950 [mdspan.extents.overview] and [mdspan.extents.cons]/12._Contains_multidimensional_index()to match its function parameters; it's always called with template argument deduction.operator[]forspan/array. Fine-grained commits for clarity:_Multidimensional_access()up.noexceptto_Multidimensional_access(), not commented as strengthened because it's_Ugly.as_const()to thearrayoverload, so it exactly matches thespanoverload.const array&has the same effect), but adding this will make the following unification clearer._Multidimensional_subscript().arrayin aspan.noexceptto_Multidimensional_subscript(not commented, it's_Ugly), then strengthenoperator[]forspan/array.span/arraysubscript operators up to parity with the multidimensional subscript operator.