Final mdspan test fixes#3954
Merged
StephanTLavavej merged 13 commits intomicrosoft:feature/mdspan2from Aug 12, 2023
Merged
Conversation
The nearby comment is intentionally unchanged.
…`layout_right` test.
… for `is_always_exhaustive()`.
…`P0009R18_mdspan_layout_right`.
…ht_mapping()` was missing "Check effects", while `check_construction_from_other_left_mapping()` was testing `layout_right::mapping` as the source.
Fix comments for `test_construction_from_[span/array]_with_invalid_values()`: `other.extent(r)` => `exts[r]` `test_construction_from_span_with_unrepresentable_as_index_type_values()` and `test_construction_from_array_with_invalid_values()` were tangled up.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
<utility>formake_index_sequence.boolunderlying types when we callto_underlying()later.Mdspan=>mdspanin comments.arrayfromstoa.ActionTrackerobservers as[[nodiscard]].M1typedef. Renamem2=>m1to avoid looking weird.Mappingtypedef, like the block immediately above, and thelayout_righttest.LyingLayoutinherits fromlayout_left::mapping<Extents>; use that foris_always_exhaustive().span<int>is inherently symmetry-breaking here.layout_stride::mappingwithout an extraspan, matchingP0009R18_mdspan_layout_right.P0009R18_mdspan_layout_right,check_construction_from_other_right_mapping()was missing "Check effects", whilecheck_construction_from_other_left_mapping()was testinglayout_right::mappingas the source.noexcept.test_construction_from_[span/array]_with_invalid_values():other.extent(r)=>exts[r]test_construction_from_span_with_unrepresentable_as_index_type_values()andtest_construction_from_array_with_invalid_values()were tangled up.