update stl/inc/xtr1common: _Is_any_of_v#3933
Conversation
|
Sorry, I was so reckless. |
|
This was my first attempt to submit a pr to a project like this, and there were a lot of things I didn't do well |
|
The CI will be restarted later. I have no idea what's wrong: "Received request to deprovision: The request was cancelled by the remote provider." But your code is fine. No changes needed. |
We use so-called "spot" VMs in Azure to minimize CI costs. They cost less, but are subject to being pulled out from underneath us without warning and reallocated to full paying customers. |
|
The MSVC compiler actually internally optimizes both |
|
We use |
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
|
Thanks for improving compiler throughput here, and congratulations on your first microsoft/STL commit! 🎉 😻 🥳 |
This is a very simple modification. The original _Is_any_of_v produces a lot of bloated unrolling. Using fold-expression is a better alternative. Because the change was so simple, I didn't issue it, and the tests were fine.