Fix string::replace under ASan#3884
Merged
StephanTLavavej merged 3 commits intomicrosoft:mainfrom Jul 20, 2023
Merged
Conversation
CaseyCarter
reviewed
Jul 17, 2023
StephanTLavavej
approved these changes
Jul 18, 2023
Comment on lines
3809
to
3811
| const auto _New_size = _Old_size + _Count - _Nx; | ||
| _ASAN_STRING_MODIFY(*this, _Old_size, _New_size); | ||
| _ASAN_STRING_REMOVE(*this); | ||
| _Mypair._Myval2._Mysize = _New_size; |
Member
There was a problem hiding this comment.
No change requested: We could fuse _New_size now, or move its definition below the _ASAN_STRING_REMOVE. This is fine as-is though.
zacklj89
approved these changes
Jul 18, 2023
Member
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
Member
|
Thanks for this important ASAN fix! 🐞 🛠️ 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3883