Change _MSVC_STL_UPDATE to June 2023#3742
Merged
StephanTLavavej merged 1 commit intomicrosoft:mainfrom Jun 15, 2023
Merged
Conversation
fsb4000
approved these changes
May 31, 2023
Contributor
fsb4000
left a comment
There was a problem hiding this comment.
Your patch is good!
The test suite failed for some unknown reason.
I pinged the Microsoft developers.
They will rerun the pipeline later.
You don't need to do anything.
This comment was marked as off-topic.
This comment was marked as off-topic.
CaseyCarter
approved these changes
May 31, 2023
Contributor
|
Looks great! I kicked the stalled test so it should run to completion now. FYI, our process is to merge things in batches, so once a second maintainer approves this will sit for a few days before being merged as part of a batch. Congratulations on your first STL contribution! |
StephanTLavavej
approved these changes
May 31, 2023
Contributor
Author
|
Thank you all for reviewing and collaboration! |
Member
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
Member
|
Thanks for updating this version macro, and congratulations on your first microsoft/STL commit! 🎉 🚀 😻 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #3741