<xlocnum>: Fix grouping for num_get#3684
Merged
CaseyCarter merged 4 commits intomicrosoft:mainfrom May 18, 2023
Merged
Conversation
Unblocking one libcxx test: - std/localization/locale.categories/category.numeric/locale.num.get/facet.num.get.members/get_long.pass.cpp
StephanTLavavej
approved these changes
May 15, 2023
barcharcraz
approved these changes
May 16, 2023
Member
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
Contributor
|
Thanks for helping to fix numerous problems in our number-parsing code. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1277.
Unblocking one libcxx test:
std/localization/locale.categories/category.numeric/locale.num.get/facet.num.get.members/get_long.pass.cppAlso moves the test for non-ending unlimited grouping to the new test file.
I'm not sure when the grouping string is
"\0"swhich means grouping is not limited:"17,,29"can be parsed without settingfailbit, and"0,x1729"should be parsed as a whole...