<ranges>: Explicitly specify the template parameters for tuple#3609
Merged
StephanTLavavej merged 1 commit intomicrosoft:mainfrom Apr 7, 2023
Merged
<ranges>: Explicitly specify the template parameters for tuple#3609StephanTLavavej merged 1 commit intomicrosoft:mainfrom
<ranges>: Explicitly specify the template parameters for tuple#3609StephanTLavavej merged 1 commit intomicrosoft:mainfrom
Conversation
JMazurkiewicz
approved these changes
Mar 31, 2023
StephanTLavavej
approved these changes
Mar 31, 2023
Member
|
Looks good to me. I'm not concerned about adding test coverage for this extremely pathological scenario. |
<ranges>: Explicitly specify the template parameters for tuple<ranges>: Explicitly specify the template parameters for tuple
strega-nil-ms
approved these changes
Apr 6, 2023
Member
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
Member
|
Thanks for noticing and fixing this problem! 🦅 😸 🛠️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Class template argument deduction for
std::tupledoes not always result in atupleof the arguments (e.g. when the first argument is apair). This PR adds the template parameters to ensure that these uses oftuplebehave as expected in pathological cases.example