Revert the ppltasks change that introduced an ole32.dll dependency#3607
Conversation
This reverts commit 26a1f76.
…in Desktop apps (microsoft#2654)" This reverts commit 80ebe87.
|
Thanks STL. Gives me a case of the Moody Blues to see it go, but agree with the call. |
|
Hey. I wanted to note that our SCADA software is too affected by this issue. |
|
@tringi As a general rule, we can't talk about release dates before they've been officially announced. In this case, I think I can get away with saying that as 17.6 Preview 6 is the current Preview release, you can look at our historical patterns (which are fairly consistent although not absolute clockwork) and guess that the production release is coming soon (whereas if we were currently something like Preview 2, it would not be "soon"). I can't be any more specific than that, sorry. |
This is a clean revert (no manual changes) of #2654 and the following #3255 (in reverse order). #3255 was a targeted fix (partial revert) for an incredibly disruptive bincompat bug, but #2654 has caused even more trouble. This full revert:
ole32.dllwas disruptive to certain exotic scenarios, andole32.dll.By performing a full revert, we no longer need the partial revert. This returns us to the state that we successfully lived with in VS 2015 through VS 2022 17.2 inclusive.
@Scottj1s, the original author of #2654, agrees with the full revert here, and has confirmed that the original affected customer who needed that change has the ability to use a workaround in perpetuity.
🪞 The mirror of this PR, MSVC-PR-462260, additionally reverts the non-GitHub change in MSVC-PR-339372 affecting
<ppltasks.h>.❕ By changing
ppltasks.cppagain, this affects the VCRedist. For the bincompat scenario involving mixing VS 2015, this should be unquestionably safe (the partial revert and the full revert result in the same behavior for the function in question, that's why the partial revert worked). For the question of when we can ship this fix, because it is urgently needed by the XStore team, we are planning to port this fix to VS 2022 17.6 before it reaches General Availability, which will require unlocking its redist, and then that unlocked redist will flow into VS 2022 17.7, so there should be no remaining mix-and-match nightmares (I hope).I am not performing any other changes or cleanups at this time (I may come back to
ppltasks.cppin the future to add some#endifcomments, but no logic changes, I have had a lifetime of being burned here).I've filed #3606 to capture the vNext comments that are being reverted here.