Fix modules test by using static constexpr arrays#3588
Merged
StephanTLavavej merged 1 commit intomicrosoft:mainfrom Mar 24, 2023
Merged
Fix modules test by using static constexpr arrays#3588StephanTLavavej merged 1 commit intomicrosoft:mainfrom
static constexpr arrays#3588StephanTLavavej merged 1 commit intomicrosoft:mainfrom
Conversation
strega-nil-ms
approved these changes
Mar 24, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This mirrors the library test changes from @JonCavesMSFT's MSVC-PR-460102.
In the header units and named modules test, I was unintentionally being a bad kitty 😼 and was exercising an accepts-invalid codepath in the MSVC compiler, which is now being fixed. Specifically, WG21-N4928 [expr.const]/12.2:
In my test code, I was constructing
constexprreverse_iterators andspans by taking the address of a non-staticconstexprarray at function scope. This is forbidden; the array must bestatic constexprfor it to work.With this change, the code is now conformant, and accepted by both the old and new compilers, so we can make the change simultaneously in MSVC and GitHub. Thanks Jonathan! 😻
(It's worth noting that both Clang and GCC correctly enforce this rule. However, the header units and named modules test currently runs for MSVC only, not EDG or Clang, which is why I missed this.)