Don't warn when using operator<=> with 0#3581
Merged
StephanTLavavej merged 6 commits intomicrosoft:mainfrom Mar 24, 2023
Merged
Don't warn when using operator<=> with 0#3581StephanTLavavej merged 6 commits intomicrosoft:mainfrom
StephanTLavavej merged 6 commits intomicrosoft:mainfrom
Conversation
StephanTLavavej
requested changes
Mar 19, 2023
Co-authored-by: Stephan T. Lavavej <stl@nuwen.net>
strega-nil-ms
approved these changes
Mar 21, 2023
Contributor
strega-nil-ms
left a comment
There was a problem hiding this comment.
This looks good to me, at least :)
StephanTLavavej
approved these changes
Mar 22, 2023
Member
|
Thanks! FYI @strega-nil-ms I pushed very minor changes after you approved. |
Member
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
Member
|
Thanks for restoring the usability of the zero-as-null-pointer-constant warning! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LLVM has an issue: llvm/llvm-project#43670
That issue marked as
libc++but actually every C++ standard library affected , and MSVC STL and libstdc++.I also created: https://reviews.llvm.org/D146372
Yes, after that patch we accept
but probably this is fine because the behavior is undefined. At least we don't warn on valid code.