Cleanups: Follow Standard order for byteswap in <bit>#3543
Merged
StephanTLavavej merged 2 commits intomicrosoft:mainfrom Mar 7, 2023
Merged
Cleanups: Follow Standard order for byteswap in <bit>#3543StephanTLavavej merged 2 commits intomicrosoft:mainfrom
byteswap in <bit>#3543StephanTLavavej merged 2 commits intomicrosoft:mainfrom
Conversation
This was introduced by GH 2235. We didn't mention Standard order while reviewing. It appears that the rationale for separating the helpers from the Standard function was that this grouped Standard functions together.
strega-nil-ms
approved these changes
Mar 6, 2023
jovibor
reviewed
Mar 6, 2023
Member
Author
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
Member
Author
|
I've resolved the trivial merge conflict. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Coalesce
_Byteswap_meowandbyteswap, follow Standard order - see WG21-N4928 [bit.syn].Programmer archaeology: This was introduced by #2235, where we simply didn't mention Standard order while reviewing. It appears that the rationale for separating the helpers was that this grouped Standard functions together. These days, we prefer to follow Standard order unless there's a strong reason not to, and we're comfortable with interleaving helpers along the way (this makes it easier to see what the helpers are doing).
Note: There will be a trivial merge conflict between this PR's code movement and #3539 editing
countl_zero's adjacent definition.