Cleanups: Drop top-level const on value params in declarations#3525
Merged
StephanTLavavej merged 2 commits intomicrosoft:mainfrom Mar 7, 2023
Merged
Conversation
strega-nil-ms
approved these changes
Mar 6, 2023
Member
Author
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While we love
constand use it almost everywhere possible, we conventionally omit it in one place. Top-levelconston value parameters in function declarations is immediately ignored by the language/compiler and serves no purpose (it makes no difference to callers).I noticed that we accumulated several occurrences of this in our declarations of parallel algorithms, so I audited all of our
_ExPo&&functions. I also noticed one more occurrence in_Buffered_inplace_merge_unchecked(). This is pretty hard to search for, so I don't claim that this is an exhaustive cleanup.