Cleanups: Formatting and comments#3523
Merged
StephanTLavavej merged 9 commits intomicrosoft:mainfrom Mar 7, 2023
Merged
Conversation
Mentioning _Count is overwhelmingly more common; _Uninitialized_value_construct_n_unchecked1 in <xmemory> doesn't even take _Count_raw.
Co-authored-by: Jakub Mazurkiewicz <mazkuba3@gmail.com>
Contributor
There was a problem hiding this comment.
I've noticed two areas where we may want further changes:
- stl/inc/iterator:255: it doesn't result in the newline going away, but we could change the
// strengthenedto a/* strengthened */before a{(I believe it's the only one left - there are still two newlines in a row between macros in
<atomic>
strega-nil-ms
approved these changes
Mar 6, 2023
Member
Author
|
Thanks @strega-nil-ms! 😻 I've pushed a conflict-free merge with |
Member
Author
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
// strengthenedputting{on the next line. This is one of the few scenarios where we prefer to use C-style comments.grapheme_break_property_data_gen.pyaccordingly (and verified that the output is identical after clang-formatting).PROP_VALUE_ENUM_TEMPLATE.lstrip()which is sufficient. But then I noticed thatDATA_ARRAY_TEMPLATEwas the only multi-line string template that we weren't stripping leading whitespace from, which seemed confusing. I think it's better to consistently strip them (so we can pretend that they didn't begin with leading whitespace at all), and then explicitly add a newline to separate the enumerator values from the table._Countinstead of_Count_raw._Countis overwhelmingly more common;_Uninitialized_value_construct_n_unchecked1in<xmemory>doesn't even take_Count_raw.